Add support for Arm Cortex-M3 (NUCLEO-F207ZG) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
potsrevennil
commented
May 15, 2024
potsrevennil
commented
- Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
mkannwischer
requested changes
May 16, 2024
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
mkannwischer
changed the title
mkannwischer
approved these changes
May 16, 2024
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @potsrevennil! Looking good to me.
I tested this on the board and it all works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.