Skip to content

Add flag to tests scripts to specfic tty device #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2024
Merged

Add flag to tests scripts to specfic tty device #40

merged 2 commits into from
May 22, 2024

Conversation

@potsrevennil
Copy link
Contributor

@potsrevennil potsrevennil commented May 22, 2024

#34

  • add -u --uart for specific tty
  • add black as python formatter
  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)

@potsrevennil
add -u --uart for specific tty
cbc5542 
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
@potsrevennil
add black as python formatter
bb8859c 
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
@potsrevennil potsrevennil marked this pull request as ready for review May 22, 2024 05:44
@potsrevennil potsrevennil requested a review from a team as a code owner May 22, 2024 05:44
@potsrevennil potsrevennil requested review from mkannwischer and removed request for a team May 22, 2024 05:44
mkannwischer
mkannwischer approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I tested it and it works fine.

@mkannwischer mkannwischer merged commit 02d6d9e into pq-code-package:main May 22, 2024
@mkannwischer mkannwischer mentioned this pull request May 22, 2024
Closed
@potsrevennil potsrevennil deleted the flag-for-tty branch May 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkannwischer mkannwischer mkannwischer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@potsrevennil @mkannwischer