Skip to content

Conversation

@potsrevennil
Copy link
Contributor

@potsrevennil potsrevennil commented May 23, 2024

#38

  • import mbed-os for emulating with nix
  • build mps2-an386 with mbed-os
  • add support for mps2-an385 and mps2-an386
  • include tests for mps2-an385/mps2-an500 in ci
  • cleanup makefile
  • add --list-platforms command
  • update README
  • refactor ci with xargs
  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)

Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
@potsrevennil potsrevennil linked an issue May 23, 2024 that may be closed by this pull request
@potsrevennil potsrevennil marked this pull request as ready for review May 23, 2024 02:55
@potsrevennil potsrevennil requested a review from a team as a code owner May 23, 2024 02:55
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
@potsrevennil potsrevennil force-pushed the qemu branch 2 times, most recently from 81cf2bb to 3d34997 Compare May 23, 2024 04:17
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor issues:

  • Please remove the hal/mps2/ directory as it's no longer needed.
  • The -v flag does not appear to work for the qemu targets (e.g., tests func mps2-an500 -v).

Rest looks good - thanks @potsrevennil

Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Signed-off-by: Thing-han, Lim <15379156+potsrevennil@users.noreply.github.com>
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me now. Thank you!

@mkannwischer mkannwischer merged commit 77e957b into pq-code-package:main May 23, 2024
@potsrevennil potsrevennil deleted the qemu branch May 24, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mps2-an385 (Cortex-M3) and mps2-an500 (Cortex-M7)

2 participants