Color Wheel LED mode & other fixes

[Pablo-Ortiz-Lopez]

This PR basically consists of the following changes:

• Add a "Color Wheel" option to the LED Color selector
• Instead of reserving a bunch of RMT channels both for LED TX and RF RX, avoid conflicts by reserving
  • Channels 0 and 1 for LED TX
  • Channel 6 for RF RX
• Add calls to tft.drawPixel(0,0,0); , which prevent the T-Embed's display from ignoring commands

The only thing that I think might spark debate (or probably not) is that I used a bruceConfig.ledColor value of 1 to store the "Color Wheel" mode, so this extremely dim, almost off color, becomes unavailable.
I don't really think it's going to be an issue but maybe you'd prefer adding an extra option to bruceConfig.

[Huzzla101]

If we could arrange something similar to the color wheel, like the fabric installment did have , it would be just magical... There must be a way we can integrate the same functions.,, When the LED changed colors around the wheel it was almost like having a Woman there but... :p Im sure we can take the "coding" they have used (lilygo manufacturers) and simply put it into Bruce... BUT i have noticed that Mr Pirata,one of the greatest Coders/Enginers known to men , dont have a T Embed CC1101 himself but Bruce going to be BIG, so i have 40USD to contribute , then its only needed about 30USD more to give him one as a gift... Anyone with a FAT pocket want to contribute?? Just holla at your dolla and let me know so we can get him one... Worst case he will get one from me before this Xmas .... Anyhow... Lets keep Rocking.... !! 😉

…

On Thu, Mar 20, 2025 at 7:20 PM Pablo Ortiz López ***@***.***> wrote: This PR basically consists of the following changes: - Add a *"Color Wheel"* option to the LED Color selector - Instead of reserving a bunch of RMT channels both for LED TX and RF RX, avoid conflicts by reserving - Channels *0* and *1* for *LED TX* - Channel *6* for *RF RX* - Add calls to tft.drawPixel(0,0,0); , which prevent the T-Embed's display from ignoring commands The only thing that I think might spark debate (or probably not) is that I used a bruceConfig.ledColor value of 1 to store the *"Color Wheel"* mode, so this extremely dim, almost off color, becomes unavailable. I don't really think it's going to be an issue but maybe you'd prefer adding an extra option to bruceConfig. ------------------------------ You can view, comment on, or merge this pull request online at: #952 Commit Summary - 75c7abe <75c7abe> Implement color wheel mode - 24faddb <24faddb> add missing tft.drawPixel(0,0,0); calls - 53012ee <53012ee> Smooth colorwheel animation File Changes (5 files <https://github.com/pr3y/Bruce/pull/952/files>) - *M* src/core/display.cpp <https://github.com/pr3y/Bruce/pull/952/files#diff-d838bb53dd12aacfabb4a664f15adda5a1c9be9244ea162c5b643b5751cf1e4e> (2) - *M* src/core/led_control.cpp <https://github.com/pr3y/Bruce/pull/952/files#diff-7f767e231ef69b11527e9a9ab1abf1f7cb2074d368a3a1ef6ecf208ed58b458b> (76) - *M* src/core/led_control.h <https://github.com/pr3y/Bruce/pull/952/files#diff-b58fa2d605201d0d0521eb52b44179e4c5b319e1562f8679bf4966b915b99943> (2) - *M* src/modules/rf/record.cpp <https://github.com/pr3y/Bruce/pull/952/files#diff-3a8de55887ecf06da709354483e830df01786c5d94d75a983578c01530b3089b> (30) - *M* src/modules/rf/rf.cpp <https://github.com/pr3y/Bruce/pull/952/files#diff-3b8d5bd99465165bfd8be252a27fd3ed566b0d8dabd20f2c00c50d834b06dc28> (30) Patch Links: - https://github.com/pr3y/Bruce/pull/952.patch - https://github.com/pr3y/Bruce/pull/952.diff — Reply to this email directly, view it on GitHub <#952>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLDL6BTIUAEHR3VIKE27WZ32VMBHVAVCNFSM6AAAAABZOE7ONWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHEZTMMZQGQ4TEMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Kind Regards Christian R. May Prosperity allways be with us!!

[rennancockles]

Don't hardcode the value 1 for color wheel. That way if we decide to change this value in the future we would have to change it in a bunch of places. The best thing would be to define a constant for that like LED_COLOR_WHEEL or something. That way we would have to change the value in a single place and it's easier to understand what that value is.

[Pablo-Ortiz-Lopez]

Don't hardcode the value 1 for color wheel. That way if we decide to change this value in the future we would have to change it in a bunch of places. The best thing would be to define a constant for that like LED_COLOR_WHEEL or something. That way we would have to change the value in a single place and it's easier to understand what that value is.

That is a great idea, just pushed the fix.