Skip to content

Conversation

@NeerajHazarika
Copy link
Contributor

@NeerajHazarika NeerajHazarika commented Oct 2, 2021

Related Issue #168

@prathimacode-hub pls review it
Issue Name : 0/1 Knapsack Problem
Closes : #168

  • Hacktoberfest2021 Participant
  • Contributor

Description

  • Created a Python script using Dynamic Programming to solve 0/1 Knapsack problem
  • Doc file explaining the entire algorithm

Type of Change

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This script or code has been tested using various test cases and scenarios.

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added test cases that prove my fix is effective or that my feature works.

- new readme.md in PyAlgo-Tree/Dynamic Programming/0 1 Knapsack/
updated readme at ./Dynamic Programming/0 1 Knapsack/
new pic added at ./Dynamic Programming/0 1 Knapsack/Images
@welcome
Copy link

welcome bot commented Oct 2, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 2, 2021
@NeerajHazarika
Copy link
Contributor Author

@prathimacode-hub is it ok ? Or does it need some changes ?

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Great work showcased. Well done. 🙌👌@NeerajHazarika

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest label Oct 3, 2021
@prathimacode-hub prathimacode-hub merged commit 2816c07 into prathimacode-hub:main Oct 3, 2021
@welcome
Copy link

welcome bot commented Oct 3, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@prathimacode-hub
Copy link
Owner

Append your name and your details in a shown format by creating a PR in CONTRIBUTORS.md over this repo @NeerajHazarika

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0/1 Knapsack Problem

2 participants