Skip to content

Improve speed of logging methods with an additional "f" suffix#116

Merged
preaction merged 3 commits intopreaction:masterfrom
XSven:master
Apr 25, 2026
Merged

Improve speed of logging methods with an additional "f" suffix#116
preaction merged 3 commits intopreaction:masterfrom
XSven:master

Conversation

@XSven
Copy link
Copy Markdown
Contributor

@XSven XSven commented Apr 8, 2026

I have removed one level of subroutine calls. Maybe related to #69

@preaction
Copy link
Copy Markdown
Owner

Thanks! This looks good as-is, though I think the conditional inside the sub that checks if it's a formatter could be skipped if instead the sub was built via string eval "sub { ... }". Then the conditional would be at "compile" time and not runtime.

If you'd like I can merge this as-is and we can leave micro-optimization as a todo. I'll do that Sunday, April 26 unless you tell me otherwise :)

@XSven
Copy link
Copy Markdown
Contributor Author

XSven commented Apr 25, 2026

Yes please go ahead and do the merge and upload a new release to CPAN. Thank you.

@preaction preaction merged commit fcfc17f into preaction:master Apr 25, 2026
preaction added a commit that referenced this pull request Apr 25, 2026
  - This release contains some performance improvements. Thanks @XSven! [Github #116]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants