Skip to content

Conversation

@mikeerickson
Copy link
Contributor

  • Convert webpack.config.js to work with webpack 2
  • Update all associated dependencies (see diff for package.json)
  • Updated README.md to reference webpack 2 instead of webpack
  • Updated version from 1.0.0 -> 1.1.0 (maintaining semver)
  • Added postcss.config.js (see file comments for reasoning)
    NOTE: I have not updated karma testing as there are some remaining issues to cure

})
];
// NOTE: This is now handled in the `postcss.config.js`
// webpack2 has some issues, making the config file necessary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will find the reasoning behind this and send it to you. I applied this fix personally sometime ago (when working with webpack beta release) and have not revistited

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First and formost, webpack 2 does not allow "custom" config properties (can only use webpack native properties).

So, the postcss.config.js replaces the use of

...
   config.postcss()
...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I ask is why an external file, I prefer everything contained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned above, I will track down where the information I gleaned as to requiring the postcss.config.js I understand what you are asking, but I am just stating that I dont recall where I say this (when I had to add it to my project).

Further, adding the postcss.config.js is the usage of .babelrc (it too could be stored in the package.json

I will track down where I found the information about needing to use postcss.config.js with webpack 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Foxandxss I believe this is where i got my information (near bottom of thread, stating postcss.config.js is required when using postcss plugins)

webpack/postcss-loader#125

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with that. Can you resolve the conflict tho?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing...

@mikeerickson
Copy link
Contributor Author

@Foxandxss OK, merge conflicts fixed

@Foxandxss Foxandxss merged commit 84c979d into preboot:master Jan 25, 2017
@Foxandxss
Copy link
Member

Thanks.

@phra
Copy link
Member

phra commented Jan 25, 2017

nice one! @mikeerickson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants