-
Notifications
You must be signed in to change notification settings - Fork 651
[065] Update to webpack 2 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[065] Update to webpack 2 #66
Conversation
| }) | ||
| ]; | ||
| // NOTE: This is now handled in the `postcss.config.js` | ||
| // webpack2 has some issues, making the config file necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will find the reasoning behind this and send it to you. I applied this fix personally sometime ago (when working with webpack beta release) and have not revistited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First and formost, webpack 2 does not allow "custom" config properties (can only use webpack native properties).
So, the postcss.config.js replaces the use of
...
config.postcss()
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I ask is why an external file, I prefer everything contained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I mentioned above, I will track down where the information I gleaned as to requiring the postcss.config.js I understand what you are asking, but I am just stating that I dont recall where I say this (when I had to add it to my project).
Further, adding the postcss.config.js is the usage of .babelrc (it too could be stored in the package.json
I will track down where I found the information about needing to use postcss.config.js with webpack 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Foxandxss I believe this is where i got my information (near bottom of thread, stating postcss.config.js is required when using postcss plugins)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with that. Can you resolve the conflict tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing...
|
@Foxandxss OK, merge conflicts fixed |
|
Thanks. |
|
nice one! @mikeerickson |

webpack.config.jsto work with webpack 2package.json)README.mdto referencewebpack 2instead ofwebpack1.0.0 -> 1.1.0(maintaining semver)postcss.config.js(see file comments for reasoning)NOTE: I have not updated karma testing as there are some remaining issues to cure