-
-
Notifications
You must be signed in to change notification settings - Fork 129
Add run/clean scripts for SU2-CalculiX and restructure files #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is now ready for review. I have tested the intended functionality (starting/cleaning) and it works. I cannot test the complete simulation, as the Solid simulation diverges in my system with |
|
@Eder-K please try to apply these changes to the system tests and approve when ready. |
uekerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
Eder-K
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The systests are updated, the test is now launched by executing the runFluid/runSolid scripts in the respective adapters.
However, the test does still fail during finalization due to a known double free error in the SU2 adapter: https://travis-ci.org/github/precice/systemtests/jobs/722485626#L30853
This is not exclusive to this new test structure though, as the current cron jobs on systemtest regularly fail with the same problem: https://travis-ci.org/github/precice/systemtests/jobs/722480420#L30824
|
I also fixed the watchpoint name in the |
The
FSI/flap_perp/SU2-CalculiXwas one of the first tutorial cases we got, as part of the BGCE project that resulted into http://run.precice.org/. Since then, we have many more cases that follow a few patterns, which this case currently ignores.This PR:
runFluidand arunSolidscript, which start the two participants separately and use both the screen andFluid.log/Solid.logfor logging (usingtee, which we could also apply into more tutorials). These files were previously calledSu2.logandCalculix.log.Allrunscript, similar to theOpenFOAM-CalculiXone.Allcleanscript.Fluid/directory (and not the root directory).exchange-directoryfrom..(flap_perp/) to the default (., i.e.SU2-CalculiX).euler_config_coupled_mergeSolution.cfgwhich was used in case of parallel simulations. This only had trivial changes, irrelevant to the parallelization (UNST_TIME,SOLUTION_FLOW_FILENAME)Todo
runTutorial_serial.shandrunTutorial_parallel.sh.README.md.I also tried a few options to reduce the verbosity of the screen output in SU2 (e.g. not print the residuals for all the iterations), but I could not succeed.
Closes #89.