Skip to content

Update FEniCS cases data initialization #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2020
Merged

Update FEniCS cases data initialization #101

merged 3 commits into from
Aug 11, 2020

Conversation

@BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Aug 11, 2020 •
edited
Loading

Ensures compatibility with changes introduced in precice/fenics-adapter#81.

Update

  • heat.py Note: Other tutorials do not use data initialization
  • cyl-flap.py uses PointSources
  • perp-flap.py uses PointSources

Check for regressions

  • heat.py
  • flap_perp
  • cylinderFlap
  • flow-over-plate

@BenjaminRodenberg BenjaminRodenberg self-assigned this Aug 11, 2020
@BenjaminRodenberg
Copy link
Member Author

BenjaminRodenberg commented Aug 11, 2020

I ran all cases and checked the precice-*-iterations.log files for the FEniCS participants. Cases worked nicely and no regression was visible.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review August 11, 2020 08:49
BenjaminRodenberg added a commit to precice/fenics-adapter that referenced this pull request Aug 11, 2020
@BenjaminRodenberg
Remove prototyping folder, updated tutorial is now available in preci…
3cc5ddb 
…ce/tutorials#101
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Aug 11, 2020
Merged
2 tasks
@IshaanDesai IshaanDesai merged commit 7a8e4f5 into develop Aug 11, 2020
@IshaanDesai IshaanDesai deleted the fenics-adapter-i80 branch November 17, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenjaminRodenberg @IshaanDesai