Initialize with V_g.sub(1) as write_object #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tested functionality of this case with:
I think it is still safe to merge this PR, since develop is fixed and the parallel setup of this case is a different story. |
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 19, 2020
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 20, 2020
BenjaminRodenberg
added a commit
that referenced
this pull request
Dec 23, 2020
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 8, 2021
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the actually correct fix for the bug mentioned in #126.
With this fix we do not have to change the OpenFOAM side of the simulation, which expects a scalar valued flux. We now provide a subspace of the vector valued function space
V_gaswrite_object.V_g.sub(1)is scalar and we can still write the scalar valued fluxflux_y.