Throw error in fenics and nutils run scripts if no argument was provided #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
approved these changes
Jun 2, 2021
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I did not test the run script, but to me this is a clear usability improvement.
Member
Author
|
@MakisH I guess this change could go to master as well?! |
Member
Is it a bugfix or a feature? If it is a bugfix, in principle it goes to master. If it is a feature/"nice to have", it goes to develop. The question is essentially how urgent and breaking it is. I guess it can go directly to master. |
Member
Author
|
You can decide yourself. It's just a usability improvement; not really a bug, not really a feature. |
Member
Author
|
There is another commit I don't want to mix here. Merging to develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing happens if no argument was provided, which is a bit unfortunate for people like me who are too lazy to read our documentation. This would be an easy fix.