Enable running the system tests in forks #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
commented
Mar 26, 2025
MakisH
commented
Mar 26, 2025
| OPENFOAM_ADAPTER_REF:${{ needs.gather-refs.outputs.ref-openfoam-adapter }},\ | ||
| SU2_VERSION:7.5.1,\ | ||
| SU2_ADAPTER_REF:${{ needs.gather-refs.outputs.ref-su2-adapter }},\ | ||
| TUTORIALS_PR:${{ github.event.number }},\ |
Member
Author
There was a problem hiding this comment.
This line needs to be ported to the workflows of other repositories (replacing the TUTORIALS_PR with, e.g., PRECICE_PR.
MakisH
commented
Mar 26, 2025
MakisH
commented
Mar 26, 2025
Member
Author
|
As I noticed some regressions when trying to run the system tests on this PR, here is a recent run that does not include these changes: https://github.com/precice/tutorials/actions/runs/14088294869/job/39458261691 |
Member
Author
|
Succeeding job with the latest changes: https://github.com/precice/tutorials/actions/runs/14112641301/job/39537745120 I will now revert the debugging-related changes in the workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards the PR number to the
systemtests.py, which then forwards it to theDockerfile, allowing agit fetch origin pull/<pr>/head.In the
Systemtest.pyclass, I had to remove a strict check (that every argument without a default value is provided), to keep the implementation relatively straight-forward.Closes #580.
Checklist:
changelog-entries/<PRnumber>.md.