Skip to content

Conversation

@mathiskelm
Copy link
Collaborator

@mathiskelm mathiskelm commented Aug 31, 2025

Checkpointing was mixed up with normal DuMux time-step advances, breaking the macro-dumux participant in the case of subcycling. Fixed checkpointing and subcycling and cleaned up the time loop.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@mathiskelm mathiskelm force-pushed the two-scale-heat-conduction/fix-subcycling-checkpointing branch from ae7ef55 to 8357262 Compare August 31, 2025 21:25
@mathiskelm mathiskelm requested a review from IshaanDesai August 31, 2025 21:28
@IshaanDesai IshaanDesai marked this pull request as ready for review September 7, 2025 12:38
@IshaanDesai IshaanDesai added the bug label Sep 7, 2025
@IshaanDesai
Copy link
Member

The results look as what we would expect them to. I would suggest leaving the smaller initial time step value for macro-dumux as it is now, which induces subcycling. That makes this tutorial a stronger test case. Changing the end time of the simulation is also not problematic in my opinion.

@IshaanDesai IshaanDesai merged commit 09ab709 into develop Sep 8, 2025
1 check passed
@IshaanDesai IshaanDesai deleted the two-scale-heat-conduction/fix-subcycling-checkpointing branch September 8, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants