Skip to content

Conversation

@my1e5
Copy link
Contributor

@my1e5 my1e5 commented Oct 15, 2025

Co-authored by: Dimitris Iliopoulos dimitris.iliopoulos@gmail.com

This PR adds support for Python 3.14 by bumping the pyo3 and rust-numpy dependencies to version 0.26. This requires a small refactor to the source code. These changes are identical to those made by @diliop in #85, so I've added them as a co-author to recognise their contribution.

Closes #87

Co-authored by: Dimitris Iliopoulos <dimitris.iliopoulos@gmail.com>
@my1e5 my1e5 mentioned this pull request Oct 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (05334d5) to head (1fed204).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #89   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       4           
  Lines        371     371           
=====================================
  Misses       371     371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #89 will degrade performances by 39.77%

Comparing my1e5:python314 (1fed204) with main (7e2f14a)

🎉 Hooray! pytest-codspeed just leveled up to 4.1.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 36 improvements
❌ 11 regressions
✅ 631 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_lttb_with_x[False-float32-1,000-1,000,000] 13.6 ms 12.3 ms +11.23%
test_lttb_with_x[False-float32-100-1,000,000] 13.7 ms 12.3 ms +11.25%
test_lttb_with_x[False-float32-5,000-1,000,000] 13.8 ms 12.4 ms +11.03%
test_lttb_with_x[False-float64-1,000-1,000,000] 14.6 ms 13.2 ms +10.47%
test_lttb_with_x[False-float64-100-1,000,000] 14.6 ms 13.2 ms +10.46%
test_lttb_with_x[False-float64-5,000-1,000,000] 14.6 ms 13.3 ms +10.31%
test_lttb_with_x[False-int32-1,000-1,000,000] 13.7 ms 12.3 ms +11.21%
test_lttb_with_x[False-int32-100-1,000,000] 13.7 ms 12.3 ms +11.28%
test_lttb_with_x[False-int32-5,000-1,000,000] 13.9 ms 12.5 ms +11.02%
test_lttb_with_x[True-float32-1,000-1,000,000] 13.7 ms 12.3 ms +11.31%
test_lttb_with_x[True-float32-100-1,000,000] 13.7 ms 12.3 ms +11.24%
test_lttb_with_x[True-float32-5,000-1,000,000] 13.8 ms 12.5 ms +10.98%
test_lttb_with_x[True-float64-1,000-1,000,000] 14.6 ms 13.2 ms +10.43%
test_lttb_with_x[True-float64-100-1,000,000] 14.6 ms 13.3 ms +10.46%
test_lttb_with_x[True-float64-5,000-1,000,000] 14.7 ms 13.3 ms +10.26%
test_lttb_with_x[True-int32-1,000-1,000,000] 13.7 ms 12.4 ms +11.21%
test_lttb_with_x[True-int32-100-1,000,000] 13.8 ms 12.4 ms +11.18%
test_lttb_with_x[True-int32-5,000-1,000,000] 13.9 ms 12.5 ms +10.95%
test_m4_no_x[True-float64-1,000-100,000] 768.1 µs 679.4 µs +13.06%
test_m4_no_x[True-float64-100-100,000] 739.8 µs 637.6 µs +16.03%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting this PR @my1e5 & @diliop

I'll create a release later today!

@jvdd jvdd merged commit db142fa into predict-idlab:main Oct 16, 2025
42 checks passed
@my1e5 my1e5 deleted the python314 branch October 16, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.14 support

3 participants