Skip to content

refactor: Use std::io::Error::other(_) and declare MSRV 1.74 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Use std::io::Error::other(_) and declare MSRV 1.74 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51855d1
refactor: Use `std::io::Error::other(_)`
musicinmybrain Aug 6, 2025
c704afd
Add an MSRV, Rust 1.74
musicinmybrain Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ description = "A library for streaming reading of files over HTTP using range re
license = "MIT"
repository = "https://github.com/prefix-dev/async_http_range_reader"
exclude = ["test-data/*"]
rust-version = "1.74"

[dependencies]
futures = "0.3.28"
Expand Down
8 changes: 4 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use reqwest::header::HeaderMap;
use reqwest::{Response, Url};
use sparse_range::SparseRange;
use std::{
io::{self, ErrorKind, SeekFrom},
io::{self, SeekFrom},
ops::Range,
pin::Pin,
sync::Arc,
Expand Down Expand Up @@ -476,7 +476,7 @@ async fn run_streamer(
.instrument(span)
.await
.and_then(error_for_status)
.map_err(|e| std::io::Error::new(ErrorKind::Other, e))
.map_err(std::io::Error::other)
{
Err(e) => {
state.error = Some(e.into());
Expand Down Expand Up @@ -585,7 +585,7 @@ impl AsyncRead for AsyncHttpRangeReader {

// If a previous error occurred we return that.
if let Some(e) = inner.streamer_state.error.as_ref() {
return Poll::Ready(Err(io::Error::new(io::ErrorKind::Other, e.clone())));
return Poll::Ready(Err(io::Error::other(e.clone())));
}

// Determine the range to be fetched
Expand Down Expand Up @@ -641,7 +641,7 @@ impl AsyncRead for AsyncHttpRangeReader {
Some(state) => {
inner.streamer_state = state;
if let Some(e) = inner.streamer_state.error.as_ref() {
return Poll::Ready(Err(io::Error::new(io::ErrorKind::Other, e.clone())));
return Poll::Ready(Err(io::Error::other(e.clone())));
}
}
}
Expand Down