Sourcing a file will lose the current PATH value

[certik]

Setting PATH and sourcing another file will lose the PATH definition

export PATH='...'
source "C:\Users\...\AppData\Local\miniforge3\envs\lf\etc\conda\activate.d\libxml2_activate.sh"

When we run this via shell --interact --norc a.sh, and do echo $PATH, it will not print the new PATH. But if we comment out the source .... line, it will print the new PATH.

I had an "exit" in the sourced script. It probably should have exited the interactive session. Removing "exit" makes it work.

[prsabahrami]

I believe the issue is that when exit is executed in the script, the code returns an ExecuteResult::Exit which does not contain the changes to env variables. Is the expected behaviour for shell to exit interactive mode or to continue and include the changes as well?
I actually just realized that if I comment the below line in crates/shell/src/main.rs:

if line.trim().eq_ignore_ascii_case("exit") {
    println!("Exiting...");
    break 
}

The shell does not exit even when we run the exit command which is defined as built-in command. Hence, let's say for example with the above not uncommented, if exit is executed in a pipeline, it does not do anything. I think the whole behaviour of exit is buggy and I'll work on fixing it!