Skip to content

Conversation

@prsabahrami
Copy link
Contributor

@prsabahrami prsabahrami commented Sep 16, 2024

Added a crate for testing. Created the repo on top of #124, so after merging this we can remove the other PR

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (8b08567) to head (2d70dc1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/shell/src/commands/which.rs 37.50% 15 Missing ⚠️
crates/shell/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   68.27%   68.67%   +0.39%     
==========================================
  Files          26       28       +2     
  Lines        2005     2062      +57     
==========================================
+ Hits         1369     1416      +47     
- Misses        636      646      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@certik
Copy link
Collaborator

certik commented Sep 17, 2024

Thanks for adding this --- I think this now tests the actual shell execution in crates/tests/src/lib.rs, correct?

I'll let @wolfv to review this. But we definitely need such tests (see #82).

@prsabahrami
Copy link
Contributor Author

Yes! This tests shell's execution.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent!

Had a few minor comments :)

@wolfv wolfv merged commit 16b3204 into main Sep 17, 2024
@wolfv wolfv deleted the test_crate branch September 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants