Skip to content

Conversation

@prsabahrami
Copy link
Contributor

@prsabahrami prsabahrami commented Sep 6, 2024

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Hofer-Julian Hofer-Julian merged commit 0a38e5d into main Sep 6, 2024
@Hofer-Julian Hofer-Julian deleted the cd branch September 6, 2024 15:28
@wolfv
Copy link
Member

wolfv commented Sep 6, 2024

I am actually wondering if that's the way to do it, because I think the shell might expand the ~. Something similar might happen for glob expressions where we should pre-process the arguments before giving them to any command.

But we can also totally fix that later! :)

@prsabahrami
Copy link
Contributor Author

I am actually wondering if that's the way to do it, because I think the shell might expand the ~. Something similar might happen for glob expressions where we should pre-process the arguments before giving them to any command.

But we can also totally fix that later! :)

Ah yes, you're right.
We can fix it in another PR later.

@prsabahrami prsabahrami mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants