fix(examples): add firebase as a dependency to complete/simple example #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 29 29
Lines 783 783
=======================================
Hits 695 695
Misses 88 88 |
Contributor
Author
|
Looks like there are issues beyond this, since Todos won't come in and can't be added. If you happen to know a quick fix, that would be helpful
|
prescottprue
changed the title
Owner
|
After adding the Firebase sdk I am seeing the todos load and can add one. I'll add support for the database emulator so we can see if it maybe has to do with the project itself |
3 tasks
prescottprue
added a commit
that referenced
this pull request
Feb 26, 2020
…ny error (#870) - @macinjoke * update roles recipe to reflect redux-auth-wrapper v2 changes * fix(examples): add firebase as a dependency to complete/simple example (#866) * chore(examples): add emulator support to simple example * Fix implicit any error Co-authored-by: Marko Elez <7696111+markoelez@users.noreply.github.com> Co-authored-by: Scott Prue <prescottprue@users.noreply.github.com> Co-authored-by: Chris Dzoba <Chris@Dzoba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you attempt to run the simple example, you will get this error:
It's pretty easily solved by the change in this PR.
Check List
If not relevant to pull request, check off as complete
Relevant Issues
Not applicable. I didn't file an issue for this. Let me know if there needs to be one.