feat: Local overwrite based on uuid #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Oct 3, 2025
Member
betodealmeida
left a comment
betodealmeida
left a comment
There was a problem hiding this comment.
Nice! I like how the old file gets deleted when the asset is renamed!
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export command validates if the exported assets already exist in the target directory, raising if any asset already exists and the
overwriteflag is not included. The current validation is solely based on the file name, which is not ideal as assets can be renamed in Superset, leading to duplicated files in the directory, and causing a race condition during import (the one imported last reflects in the UI).This PR updates the logic to first check by file name, and then checks by
uuid.