After the latest release fetching of json files results in `responseText` to be the response string and the `response` field to be null

[ViktorSoroka07]

[kellyselden]

I thought response was a previously unused property. Are you saying it used to be populated with something?

[ViktorSoroka07]

Yes, we use it in combination with whatwg-fetch for testing. The thing is that whatwg-fetch relies on the response field. https://github.com/github/fetch/blob/master/fetch.js#L462

[kellyselden]

What were the two properties set to before the change?

[ViktorSoroka07]

Before the change

After the change (basically now)

Basically, the issue for me is that now the expression below
var body = 'response' in xhr ? xhr.response : xhr.responseText; evaluates to the xhr.response even though it is null. Previously, it evaluated to the xhr.responseText.

[ViktorSoroka07]

As I see the issue is that response is not being copied by Pretender

https://github.com/pretenderjs/pretender/blob/master/src/index.ts#L116

after the call there

https://github.com/pretenderjs/pretender/blob/master/src/index.ts#L159

So even in your code, you update them both, the Pretender does not update them accordingly and thus response field will always be null at the end in my case.

[kellyselden]

It looks like it needs this code to be correct pretenderjs/pretender#280

[ViktorSoroka07]

Yeah. Cool that PR already exists for that.

[ViktorSoroka07]

@cowboyd, as I see https://github.com/thefrontside/bigtest/tree/master/packages/mirage is archived now. Will it be possible after the pretenderjs/pretender#280 is merged to update the dependency to it?

[xg-wang]

@VictorSoroka1 just released https://github.com/pretenderjs/pretender/releases/tag/v3.1.0.
Can you try upgrade it?

[cowboyd]

@VictorSoroka1 Sorry, I'm not sure I follow. We archived that packages since https://github.com/miragejs/miragejs is now a thing. I'm happy to do whatever, but not understanding quite what that is :)