Skip to content

Commit 1eedfce

Browse files
dgp1130AndrewKushnir
authored andcommitted
refactor(devtools): remove input/output/property links (angular#60284)
These links aren't that helpful in the context of Angular DevTools for a few reasons: 1. Users of the extension should already have a general understanding of core Angular concepts, inputs and outputs included. 2. The input and output links go to API documentation which isn't useful for someone who doesn't actually understand the core concepts anyways. 3. These links point to signals documentation even though DevTools shows non-signal inputs and outputs. 4. Properties linked to template binding docs, which doesn't *really* have anything to do with the plain JS properties being shown in DevTools anyways. PR Close angular#60284
1 parent a1cacc5 commit 1eedfce

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/property-view-body.component.html

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,7 @@
2727
@if (!panel.hidden) {
2828
<mat-expansion-panel [class]="panel.class" [expanded]="true">
2929
<mat-expansion-panel-header collapsedHeight="25px" expandedHeight="25px">
30-
<mat-panel-title>
31-
{{ panel.title }}
32-
<a
33-
href="{{ panel.documentation }}"
34-
target="_blank"
35-
class="documentation"
36-
matTooltip="Open docs reference"
37-
(click)="$event.stopPropagation()"
38-
>
39-
<mat-icon class="docs-link">open_in_new</mat-icon>
40-
</a>
41-
</mat-panel-title>
30+
<mat-panel-title>{{ panel.title }}</mat-panel-title>
4231
</mat-expansion-panel-header>
4332
<ng-property-view-tree
4433
[dataSource]="panel.controls.dataSource"

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab/property-view/property-view-body.component.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ export class PropertyViewBodyComponent {
5151
title: string;
5252
hidden: boolean;
5353
controls: DirectiveTreeData;
54-
documentation: string;
5554
class: string;
5655
}[]
5756
>(() => {
@@ -60,21 +59,18 @@ export class PropertyViewBodyComponent {
6059
title: 'Inputs',
6160
hidden: this.directiveInputControls().dataSource.data.length === 0,
6261
controls: this.directiveInputControls(),
63-
documentation: 'https://angular.dev/api/core/input',
6462
class: 'cy-inputs',
6563
},
6664
{
6765
title: 'Outputs',
6866
hidden: this.directiveOutputControls().dataSource.data.length === 0,
6967
controls: this.directiveOutputControls(),
70-
documentation: 'https://angular.dev/api/core/output',
7168
class: 'cy-outputs',
7269
},
7370
{
7471
title: 'Properties',
7572
hidden: this.directiveStateControls().dataSource.data.length === 0,
7673
controls: this.directiveStateControls(),
77-
documentation: 'https://angular.dev/guide/templates/property-binding',
7874
class: 'cy-properties',
7975
},
8076
];

0 commit comments

Comments
 (0)