-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Prettier 3.0 by default #3069
Use Prettier 3.0 by default #3069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just run yarn run prettier
Thank you for all the hard work. ❤️ |
Seems like the natural thing to do, waiting for this 👍🏼 |
import * as meriyahPlugin from "prettier/plugins/meriyah"; | ||
import * as typescriptPlugin from "prettier/plugins/typescript"; | ||
import * as yamlPlugin from "prettier/plugins/yaml"; | ||
// @ts-expect-error -- d.ts file missing estree plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is the best way to handle it. Maybe add a .d.ts file locally instead?
@ntotten Now that this PR has been reverted in ad1d008 and the latest Or is there a plan for releasing this as non-preview version? What is a quick description of the problems that caused the revert? I guess a workaround switch to integrated Prettier v3 is to downgrade the extension to |
@ntotten we could also open a new issue to track Prettier v3 support, since the VS Code extension page still reports |
Oh, looks like (judging from the VS Code extension Marketplace page) the So one fewer workaround here 😬 Maybe downgrading to |
To be clear, the problem still exists with The following div {
transition:
transform 0.15s,
color 0.15s;
} will be formatted to the following with div {
transition: transform 0.15s, color 0.15s;
} Endless diffs back and forth 😬 Kapture.2023-11-18.at.19.17.45.mp4 |
@ntotten what's the way forward here for a 3.0 upgrade? Any way to help? |
Oh looks like there's a new PR mentioning Prettier v3 over here: |
@@ -260,7 +260,7 @@ | |||
"es5", | |||
"all" | |||
], | |||
"default": "es5", | |||
"default": "all", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sosukesuzuki, @ntotten, I realize the upgrade to v3 is currently blocked on this extension.
However, since Prettier v3 was released almost a year ago, how would you feel about proactively setting this default to all
(even with the current v2 support) to be future-proof?
I'm happy to open a PR if it helps :)
CHANGELOG.md
with a summary of your changes