Skip to content

feat: Spinner component#1232

Merged
dgreif merged 3 commits into
mainfrom
spinner
May 17, 2021
Merged

feat: Spinner component#1232
dgreif merged 3 commits into
mainfrom
spinner

Conversation

@dgreif

@dgreif dgreif commented May 17, 2021

Copy link
Copy Markdown
Member

This is a basic Spinner component which renders a simple spinner SVG with rotation. Besides COMMON system props, the only option is size, which is currently limited to 'small' | 'medium' | 'large'. This matches the behavior of the PVC spinner. Although the docs/tests are all done, I'm marking this as an alpha to start with, just in case we decide to change the type for size.

Closes https://github.com/github/primer/issues/165

Screenshots

CleanShot 2021-05-17 at 14 37 12

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@dgreif dgreif requested a review from colebemis May 17, 2021 21:48
@changeset-bot

changeset-bot Bot commented May 17, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2eb3d92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented May 17, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/BsRJe4PjCkHt84Zutji353rYdmpy
✅ Preview: https://primer-components-git-spinner-primer.vercel.app

@colebemis colebemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this, @dgrief. Just needs a changeset.

@vercel vercel Bot temporarily deployed to Preview May 17, 2021 22:18 Inactive
@dgreif dgreif merged commit 6800c60 into main May 17, 2021
@dgreif dgreif deleted the spinner branch May 17, 2021 23:01
@github-actions github-actions Bot mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants