Skip to content

fix: Hide intra-'Item' dividers on ':hover' and ':focus'#1259

Merged
smockle merged 3 commits into
mainfrom
hide-dividers
May 28, 2021
Merged

fix: Hide intra-'Item' dividers on ':hover' and ':focus'#1259
smockle merged 3 commits into
mainfrom
hide-dividers

Conversation

@smockle

@smockle smockle commented May 27, 2021

Copy link
Copy Markdown
Member

Fixes https://github.com/github/primer/issues/180

Screenshots

:hover
Screen recording of disappearing dividers when 'Item's are hovered

:focus
Screen recording of disappearing dividers when 'Item's are focused

All ActionList stories
Screen recording of disappearing dividers in every 'ActionList' story

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot

changeset-bot Bot commented May 27, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2c243dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented May 27, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/EvGG2Lbbzi1b2mb7QX8icPxqdqiv
✅ Preview: https://primer-components-git-hide-dividers-primer.vercel.app

Comment thread src/ActionList/Item.tsx
Comment thread src/ActionList/Item.tsx

@dgreif dgreif left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing out these styles! I think this will feel way more natural

@vercel vercel Bot temporarily deployed to Preview May 27, 2021 21:58 Inactive
@vdepizzol

vdepizzol commented May 28, 2021

Copy link
Copy Markdown
Contributor

❤ ❤ ❤

@vercel vercel Bot temporarily deployed to Preview May 28, 2021 19:47 Inactive
@smockle smockle merged commit 1585064 into main May 28, 2021
@smockle smockle deleted the hide-dividers branch May 28, 2021 19:51
@github-actions github-actions Bot mentioned this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants