Add rules to detect unmerged className and event handlers with spread props #441
+703
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #437. When spread props appear before
classNameor event handlers, the spread values get silently overridden unless explicitly merged. This implements detection for these cases.Changes
New Rules
merge-spread-props-classname: DetectsclassNameafter spread props without mergingclsx,classnames,classNames,cnclsx(rest.className, value)merge-spread-props-event-handlers: Detects event handlers after spread props without mergingonClick,onChange, etc.)compose,composeEventHandlers,composeHandlerscompose(rest.handlerName, handler)Smart Detection
Both rules only trigger when:
Example
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.