-
Notifications
You must be signed in to change notification settings - Fork 645
Refactor to styled-components #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically deployed with Now. |
shawnbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is EPIC, @emplums. Nice work! 👏
|
I'm sure you're aware that there are a ton of console errors in the test suite. Let me know if I can help you work through some of those. |
mxstbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave the diff a quick read, this looks amazing! 👏👏👏 Good job! 💯
src/Text.js
Outdated
| Text.propTypes = { | ||
| ...TYPOGRAPHY.propTypes, | ||
| ...COMMON.propTypes, | ||
| is: PropTypes.oneOfType([PropTypes.string, PropTypes.func]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be PropTypes.node instead of PropTypes.func? As far as I can tell the way the is prop is implemented should mean any element or component can be passed, not just function components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
|
Going to merge this into the release branch and do a separate docs PR! |
mxstbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉
Refactors all of our components to use
styled-componentsand removes oursystem-componentcustom setup 🙌Notes:
<Link><Octicon/><Link>To Do
isto all propTypes objects that use itthemeto all propTypes