Add fontStyle prop to TYPOGRAPHY #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
emplums
reviewed
Jan 22, 2019
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
Looks good to me! The only thing is that Heading, Link and BaseStyles all also get the TYPOGRAPHY group of props, so we should probably add this test to those component's test files as well.
Contributor
Author
|
Okay, I switched the Text test to use |
emplums
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
fontStyleto the list of typography props and a test that ensures it's respected. This is so that we can do the following in the Primer CSS docs:rather than: