Allow keyboard navigation to dialog's scroll region #4000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b9f520b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Dec 11, 2023
Co-authored-by: Josh Black <joshblack@github.com>
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This reverts commit 37d3231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility-audits/issues/5565 (GitHub staff only)
This pull request fixes an accessibility issue in Dialog where the dialog's scrollable body could not be focused with the keyboard, preventing keyboard users from navigating to the dialog content.
Changelog
New
Changed
Fix an issue where the scrollable Dialog body could not be focused with the keyboard.
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.