Skip to content

Switch flex order prop to flex item component #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2019
Merged

Switch flex order prop to flex item component #406

merged 4 commits into from
Feb 20, 2019

Conversation

@emplums
Copy link

@emplums emplums commented Feb 19, 2019

Moves the order prop to be available on Flex.Item instead of Flex

Closes #405

Merge checklist

  • Changed base branch to release branch
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@emplums emplums requested a review from shawnbot February 19, 2019 07:38
@emplums emplums changed the base branch from master to release-11.0.0 February 19, 2019 19:21
shawnbot
shawnbot approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@emplums emplums merged commit 5871ad8 into release-11.0.0 Feb 20, 2019
@emplums emplums deleted the flex-order branch February 20, 2019 17:20
@emplums emplums mentioned this pull request Feb 20, 2019
Merged
4 tasks
@emplums emplums mentioned this pull request Mar 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shawnbot shawnbot shawnbot approved these changes

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emplums @shawnbot @colebemis