Fix default font weight & size in Heading #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: "publish" + "deploy" need "npm install"
colebemis
reviewed
Feb 19, 2019
|
|
||
| const Heading = styled(Base)` | ||
| font-weight: ${get('fontWeights.bold')}; | ||
| font-size: ${get('fontSizes.5')}; |
Contributor
There was a problem hiding this comment.
Is there a heuristic for deciding whether to set default styles in the styled call vs in defaultProps? It looks like we do both in this component.
Author
There was a problem hiding this comment.
Yeah so, if you set the default in defaultProps you can't pull custom theme values from a user provided theme, so ideally default values should always be set in styled if you'd like to be able to do that. For the margin value here tbh I should probably move that into styled as well
Contributor
There was a problem hiding this comment.
Oh gotcha. That makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default font weight for the
Headingcomponent to600and moves the default text size into the styled-component declarationCloses #402
Merge checklist