DRY up constants.js #412
Merged
DRY up constants.js #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: "publish" + "deploy" need "npm install"
colebemis
commented
Feb 19, 2019
| export const FLEX_ITEM = composeList(FLEX_ITEM_LIST) | ||
|
|
||
| function composeList(list) { | ||
| return compose(...list.map(name => styles[name])) |
Contributor
Author
There was a problem hiding this comment.
I'm not 100% sure what the best name for this function and its argument is 🤷♂️
There was a problem hiding this comment.
I think this is pretty good naming as is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each "system prop" is listed twice in
constants.js: once for use withstyled-componentsand once for the docs. It seems like it would be easy for the docs to get out-of-sync if we forget to update both lists every time we make a change to a constant. I wrote a little helper function to avoid having to repeat lists of system props.Merge checklist