ButtonGroup: Fix button and icon button styling when tooltips are used on them (#4210) #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on them (#4210) * fix button group styling for tooltip and tooltip v2 * Add changeset * take the a tag into account when styling * add e2e tests for the buttons groups that use tooltip * test(vrt): update snapshots --------- Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
🦋 Changeset detectedLatest commit: f440bec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Feb 20, 2024
broccolinisoup
added
update snapshots
broccolinisoup
force-pushed
the
re-introduce-button-group-tooltip-fix
branch
from
4a24bf5 to
acfa559
Compare
broccolinisoup
added
update snapshots
broccolinisoup
removed
the
update snapshots
broccolinisoup
added
the
update snapshots
broccolinisoup
added
update snapshots
github-actions
bot
removed
the
update snapshots
I think it is all gone now, removing the strict threshold worked 👍🏻 |
langermank
approved these changes
Mar 4, 2024
|
closing this in favour of #4371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4129
Reintroducing #4210 since it is reverted due to random VRT tests failings - I removed the threshold setting in Playwright since the default one is less strict.
Changelog
New
Changed
Updated Button group CSS to make sure the icon buttons and buttons are rendered as expected when they have tooltips (both v1 and v2) on them
Removed
Rollout strategy
Testing & Reviewing
Merge checklist