Skip to content

chore(deps): remove @react-aria/ssr package #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2024
Merged

chore(deps): remove @react-aria/ssr package #4350

merged 3 commits into from
Mar 12, 2024

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Mar 4, 2024

Remove the @react-aria/ssr package from @primer/react as it is no longer used as of v36. This also removes the SSR docs as they are no longer relevant as of v36.

Changelog

New

Changed

Removed

  • Remove @react-aria/ssr from `package.json

Rollout strategy

  • None; if selected, include a brief description as to why

This change removes a dependency from the project that is not imported or used and should not impact the public API

@joshblack joshblack requested review from a team and langermank March 4, 2024 18:47
@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fc6512c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack requested a review from siddharthkp March 4, 2024 18:48
@joshblack joshblack mentioned this pull request Mar 4, 2024
Closed
@joshblack joshblack added the skip changeset This change does not need a changelog label Mar 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.71 KB (0%)
packages/react/dist/browser.umd.js 114.38 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4350 March 4, 2024 18:52 Inactive
@joshblack joshblack requested a review from a team as a code owner March 8, 2024 15:08
@joshblack
Copy link
Member Author

joshblack commented Mar 8, 2024

bump @siddharthkp when you get a sec 👀

siddharthkp
siddharthkp approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right! Deleting a page in docs oddly feels good! 😇

Heads up, we would need to remove this page from the new docs as well: https://primer.style/guides/react/ssr

@joshblack joshblack mentioned this pull request Mar 12, 2024
Merged
@joshblack
Copy link
Member Author

joshblack commented Mar 12, 2024

Ooo great point @siddharthkp, PR opened: primer/design#743

@joshblack joshblack added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 6d88f92 Mar 12, 2024
@joshblack joshblack deleted the chore/deps-remove-react-aria-ssr branch March 12, 2024 20:05
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
@joshblack @lukasoppermann
chore(deps): remove @react-aria/ssr package (#4350)
74ad57f 
* chore(deps): remove @react-aria/ssr package

* docs: remove ssr docs

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@pouretrebelle pouretrebelle mentioned this pull request Jul 24, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@langermank langermank Awaiting requested review from langermank

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @siddharthkp