Skip to content

Remove unwanted box-shadow on inactive buttons #6981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 16, 2025
Merged

Remove unwanted box-shadow on inactive buttons #6981

merged 11 commits into from
Oct 16, 2025

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Oct 10, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/5312

Changelog

New

Changed

  • Fixes visual design bug where "inactive" buttons had an unwanted box-shadow

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2700ee2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 10, 2025 18:43 Inactive
@mperrotti mperrotti added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 10, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 10, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 10, 2025 19:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 14, 2025 18:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 14, 2025 19:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 15, 2025 22:43 Inactive
@mperrotti mperrotti marked this pull request as ready for review October 16, 2025 14:19
@mperrotti mperrotti requested a review from a team as a code owner October 16, 2025 14:19
Copilot
Copilot AI reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new Link variant to LinkButton stories and e2e coverage, and removes an unintended box-shadow from inactive buttons to address a visual design bug.

  • Added 'link' to Playground variant options and a dedicated Link variant story
  • Added e2e test entry for the new Link variant
  • Fixed inactive button styling by explicitly removing box-shadow

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/react/src/Button/LinkButton.stories.tsx Adds 'link' to variant options for interactive Storybook controls
packages/react/src/Button/LinkButton.features.stories.tsx Introduces a Link variant story for visual/example coverage
packages/react/src/Button/ButtonBase.module.css Removes unwanted box-shadow from inactive button state
e2e/components/LinkButton.test.ts Adds e2e test mapping for the new Link variant story

@mperrotti mperrotti changed the title Button papercuts Remove unwanted box-shadow on inactive buttons Oct 16, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 16, 2025 14:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 16, 2025 14:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6981 October 16, 2025 15:07 Inactive
francinelucca
francinelucca approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one non-blocking question.
Also I think you need to update snapshots for the new story

packages/react/src/Button/LinkButton.stories.tsx
type: 'radio',
},
options: ['default', 'primary', 'danger', 'invisible', 'outline'],
options: ['default', 'primary', 'danger', 'invisible', 'outline', 'link'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean adding?

@mperrotti mperrotti added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2025
@primer primer bot requested a review from a team as a code owner October 16, 2025 15:21
@primer primer bot requested a review from langermank October 16, 2025 15:21
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2025
@mperrotti mperrotti added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 3099210 Oct 16, 2025
42 checks passed
@mperrotti mperrotti deleted the mp/button-papercuts-oct2025 branch October 16, 2025 15:40
@primer primer bot mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@siddharthkp siddharthkp siddharthkp approved these changes

@francinelucca francinelucca francinelucca approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mperrotti @siddharthkp @francinelucca @Copilot