-
Notifications
You must be signed in to change notification settings - Fork 646
Remove flaky IconButton tests #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes flaky snapshot tests for IconButton keybinding hints that relied on timing-sensitive interactions and tooltip visibility. The keybinding functionality is now covered by more reliable snapshot tests elsewhere.
Key Changes:
- Removed two keybinding hint test stories with complex timing requirements
- Simplified test setup by removing conditional story setup logic
- Removed unused
Pagetype import
Remove flaky snapshot tests in favor of the newer Keybinding snapshots