Skip to content

Conversation

@langermank
Copy link
Contributor

Remove flaky snapshot tests in favor of the newer Keybinding snapshots

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: 8706b11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 10, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 10, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6983 October 10, 2025 20:47 Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes flaky snapshot tests for IconButton keybinding hints that relied on timing-sensitive interactions and tooltip visibility. The keybinding functionality is now covered by more reliable snapshot tests elsewhere.

Key Changes:

  • Removed two keybinding hint test stories with complex timing requirements
  • Simplified test setup by removing conditional story setup logic
  • Removed unused Page type import

@langermank langermank added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit d8b0e1b Oct 10, 2025
42 checks passed
@langermank langermank deleted the delete-those-annoying-snaps branch October 10, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants