Skip to content

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 15, 2025

Part of https://github.com/github/primer/issues/5425

Changelog

New

  • Box component in @primer/styled-react

Changed

  • updated imports in @primer/styled-react to pull from local Box component

Removed

  • exports for Box, BoxProps in @primer/react

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner October 15, 2025 16:17
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: 7893bcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Box and BoxProps exports from the main @primer/react package while maintaining backward compatibility in the legacy @primer/styled-react package by implementing a local styled-components-based Box component.

Key Changes:

  • Removed Box and BoxProps from @primer/react package exports
  • Implemented a standalone Box component in @primer/styled-react with deprecation warnings
  • Updated all internal imports to use the local Box implementation

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/react/src/index.ts Removed Box and BoxProps exports from main package
packages/styled-react/src/components/Box.tsx Implemented local Box component with styled-system and deprecation warnings
packages/styled-react/src/components/RelativeTime.tsx Updated to import Box from local components
packages/styled-react/src/components/RadioGroup.tsx Updated to import Box from local components
packages/styled-react/src/components/NavList.tsx Updated to import Box from local components
packages/styled-react/src/components/CheckboxGroup.tsx Updated to import Box from local components
packages/react/src/tests/snapshots/exports.test.ts.snap Updated snapshot to reflect removed exports
packages/react/src/tests/ThemeProvider.test.tsx Updated test to import Box from local module

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-7015 October 15, 2025 16:23 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7015 October 15, 2025 16:36 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4724

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 15, 2025
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 15, 2025
@francinelucca francinelucca added this pull request to the merge queue Oct 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
@francinelucca francinelucca added this pull request to the merge queue Oct 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 0889246 Oct 16, 2025
42 checks passed
@francinelucca francinelucca deleted the chore/remove-box-exports branch October 16, 2025 01:42
@primer primer bot mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants