-
Notifications
You must be signed in to change notification settings - Fork 639
chore: remove Box, BoxProps export #7015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7893bcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the Box
and BoxProps
exports from the main @primer/react
package while maintaining backward compatibility in the legacy @primer/styled-react
package by implementing a local styled-components-based Box component.
Key Changes:
- Removed
Box
andBoxProps
from@primer/react
package exports - Implemented a standalone Box component in
@primer/styled-react
with deprecation warnings - Updated all internal imports to use the local Box implementation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/react/src/index.ts | Removed Box and BoxProps exports from main package |
packages/styled-react/src/components/Box.tsx | Implemented local Box component with styled-system and deprecation warnings |
packages/styled-react/src/components/RelativeTime.tsx | Updated to import Box from local components |
packages/styled-react/src/components/RadioGroup.tsx | Updated to import Box from local components |
packages/styled-react/src/components/NavList.tsx | Updated to import Box from local components |
packages/styled-react/src/components/CheckboxGroup.tsx | Updated to import Box from local components |
packages/react/src/tests/snapshots/exports.test.ts.snap | Updated snapshot to reflect removed exports |
packages/react/src/tests/ThemeProvider.test.tsx | Updated test to import Box from local module |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4724 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 ci completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Part of https://github.com/github/primer/issues/5425
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist