Skip to content

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 17, 2025

Closes https://github.com/github/primer/issues/6002

Fixes bug where Radio is not being displayed in single select modals when elements with attribute hidden have display: none

Changelog

Removed

  • hidden prop from SelectPanel Radio Selection

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner October 17, 2025 14:40
Copy link

changeset-bot bot commented Oct 17, 2025

🦋 Changeset detected

Latest commit: 67b222e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 17, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the hidden attribute from the visual-only Radio used inside Selection to fix a bug where it was not displayed in single-select modals when [hidden] elements are globally styled with display: none.

  • Removed hidden attribute from the Radio to allow it to render visually.
  • Retained aria-hidden and tabIndex to keep it out of the accessibility tree, but the comment was not updated to explain the change.

@github-actions github-actions bot requested a deployment to storybook-preview-7030 October 17, 2025 14:47 Abandoned
@siddharthkp
Copy link
Member

siddharthkp commented Oct 17, 2025

Sorry, to be able to review this, can I ask for more context. Why we add hidden (in #6330) and why we are we removing it now.

Update: Got some context on internal slack

@francinelucca francinelucca added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit 52d6cf7 Oct 20, 2025
43 checks passed
@francinelucca francinelucca deleted the fix/remove-hidden-from-selection-radio branch October 20, 2025 18:58
@primer primer bot mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants