-
Notifications
You must be signed in to change notification settings - Fork 639
fix(SelectPanel): remove hidden attribute from selection Radio #7030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 67b222e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes the hidden attribute from the visual-only Radio used inside Selection to fix a bug where it was not displayed in single-select modals when [hidden] elements are globally styled with display: none.
- Removed hidden attribute from the Radio to allow it to render visually.
- Retained aria-hidden and tabIndex to keep it out of the accessibility tree, but the comment was not updated to explain the change.
Sorry, to be able to review this, can I ask for more context. Why we add Update: Got some context on internal slack |
Closes https://github.com/github/primer/issues/6002
Fixes bug where Radio is not being displayed in single select modals when elements with attribute
hidden
havedisplay: none
Changelog
Removed
hidden
prop from SelectPanel Radio SelectionRollout strategy
Testing & Reviewing
Merge checklist