Skip to content

Not everything is a component #7074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mperrotti merged 1 commit into from
Oct 24, 2025
Merged

Not everything is a component #7074

mperrotti merged 1 commit into from
Oct 24, 2025

Conversation

@mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Oct 24, 2025

Closes #6971

@mperrotti mperrotti requested a review from a team as a code owner October 24, 2025 20:25
Copilot AI review requested due to automatic review settings October 24, 2025 20:25
@mperrotti mperrotti added the skip changeset This change does not need a changelog label Oct 24, 2025
@mperrotti mperrotti requested a review from pksjce October 24, 2025 20:25
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: 50ab279

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the principle "Everything is a component" from the contributor documentation, acknowledging that not all design system elements should be implemented as React components.

Key Changes:

  • Removal of an outdated architectural principle that may have been encouraging over-componentization

@mperrotti mperrotti enabled auto-merge October 24, 2025 20:28
@mperrotti mperrotti added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit b4439b3 Oct 24, 2025
49 checks passed
@mperrotti mperrotti deleted the mp/not-everything-is-component branch October 24, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@joshblack joshblack joshblack approved these changes

@pksjce pksjce Awaiting requested review from pksjce pksjce is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: not everything is a component anymore

3 participants

@mperrotti @joshblack