Skip to content

Remove feature flag primer_react_use_styled_react_theming #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2025
Merged

Remove feature flag primer_react_use_styled_react_theming #7180

merged 3 commits into from
Nov 13, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 11, 2025 •
edited by siddharthkp
Loading

Cleaning up primer_react_use_styled_react_theming feature flag now that it has 100% rolled out.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 92e17e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp
Remove feature flag primer_react_use_styled_react_theming
136384f 
Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove feature flag primer_react_use_styled_react_theming Remove feature flag primer_react_use_styled_react_theming Nov 11, 2025
Copilot AI requested a review from siddharthkp November 11, 2025 04:09
Copilot finished work on behalf of siddharthkp November 11, 2025 04:09
@siddharthkp siddharthkp marked this pull request as ready for review November 11, 2025 05:11
@siddharthkp siddharthkp requested a review from a team as a code owner November 11, 2025 05:11
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 11, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@siddharthkp siddharthkp removed the skip changeset This change does not need a changelog label Nov 11, 2025
Copilot finished reviewing on behalf of siddharthkp November 11, 2025 05:13
Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the primer_react_use_styled_react_theming feature flag by treating it as permanently enabled. The flag was only used in test setup for @primer/styled-react and never gated production behavior.

Key Changes

  • Removed primer_react_use_styled_react_theming from DefaultFeatureFlags
  • Removed FeatureFlags wrapper components from 29 test cases in ThemeProvider.browser.test.tsx
  • Removed unused FeatureFlags import from the test file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Removed primer_react_use_styled_react_theming: false flag declaration
packages/styled-react/src/tests/ThemeProvider.browser.test.tsx Removed FeatureFlags import and all 29 wrapper instances around ThemeProvider test components

siddharthkp
siddharthkp approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human approved

@github-actions github-actions bot temporarily deployed to storybook-preview-7180 November 11, 2025 05:22 Inactive
francinelucca
francinelucca approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@francinelucca francinelucca added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit f051a39 Nov 13, 2025
49 checks passed
@francinelucca francinelucca deleted the copilot/remove-feature-flag-primer-react-styling branch November 13, 2025 04:09
@primer primer bot mentioned this pull request Nov 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@francinelucca francinelucca francinelucca approved these changes

@llastflowers llastflowers Awaiting requested review from llastflowers llastflowers is a code owner automatically assigned from primer/engineer-reviewers

+1 more reviewer

@siddharthkp siddharthkp siddharthkp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@siddharthkp siddharthkp

Copilot code review Copilot

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp @francinelucca