chore: remove styled PageLayout #7191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ddd169b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
requested a deployment
to
storybook-preview-7191
…act into chore/remove-styled-pagelayout
github-actions
bot
requested a deployment
to
storybook-preview-7191
…act into chore/remove-styled-pagelayout
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the PageLayout component from the @primer/styled-react package as it has no internal usage. This is a breaking change marked appropriately as a major version bump.
Key changes:
- Removes PageLayout component and its type exports from the package
- Removes associated tests for PageLayout
- Updates export snapshots to reflect the removal
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/styled-react/src/index.tsx | Removes PageLayout and PageLayoutProps export statement |
| packages/styled-react/src/components/PageLayout.tsx | Deletes the entire PageLayout component implementation file |
| packages/styled-react/src/tests/primer-react.browser.test.tsx | Removes PageLayout import and all related test cases |
| packages/styled-react/src/tests/snapshots/exports.test.ts.snap | Updates snapshot to remove PageLayout from exports list |
| .changeset/clever-pumpkins-train.md | Adds changeset documenting the removal as a major version change |
TylerJDev
approved these changes
Nov 13, 2025
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6884 |
github-actions
bot
added
the
integration-tests: passing
|
🟢 ci completed with status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No internal usage so removing