-
Notifications
You must be signed in to change notification settings - Fork 645
feat(NavList): add support for inline and block description #7194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d81a127 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for inline and block descriptions in NavList by exporting ActionList.Description as a NavList subcomponent. This enables NavList items to display additional descriptive text in two variants: inline (beside primary text) or block (below primary text).
- Exported ActionList.Description as NavList.Description
- Added new "With Description" story demonstrating both inline and block variants
- Documented the Description component with its props in the docs.json file
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/NavList/NavList.tsx | Exports ActionList.Description as NavList.Description subcomponent |
| packages/react/src/NavList/NavList.features.stories.tsx | Adds comprehensive story showcasing inline and block description variants |
| packages/react/src/NavList/NavList.docs.json | Documents NavList.Description props and adds story reference |
| e2e/components/NavList.test.ts | Adds e2e test entry for the new description feature |
| .changeset/happy-clocks-cover.md | Documents the feature addition as a minor version change |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
liuliu-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6883 |
|
🟢 ci completed with status |
Closes https://github.com/github/primer/issues/6085
Changelog
New
Rollout strategy
Testing & Reviewing
Merge checklist