Skip to content

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Nov 18, 2025

Just making sure that KeybindingHint and count look alright in ActionList with the danger variant (hover state is the critical one).

CleanShot.2025-11-18.at.15.54.00.mp4
CleanShot.2025-11-18.at.15.54.28.mp4

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: ba83cda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 18, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

⚠️ No Changeset found

Latest commit: e246dc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-7211 November 18, 2025 19:55 Inactive
@langermank langermank added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Nov 18, 2025
Adjusts the CSS for the danger variant of ActionList.Item to support a trailing count or keybinding hint.
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 18, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7211 November 18, 2025 22:30 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 18, 2025
@langermank langermank marked this pull request as ready for review November 18, 2025 23:55
@langermank langermank requested a review from a team as a code owner November 18, 2025 23:55
Copilot AI review requested due to automatic review settings November 18, 2025 23:55
@langermank langermank requested a review from a team as a code owner November 18, 2025 23:55
@langermank langermank requested a review from mperrotti November 18, 2025 23:55
Copilot finished reviewing on behalf of langermank November 18, 2025 23:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the CSS for the ActionList.Item danger variant to properly support trailing count labels and keyboard binding hints, particularly focusing on the hover state styling. The previous implementation used overly broad selectors (& * :not([popover], .TrailingVisual)) which didn't adequately handle the new trailing elements.

Key Changes:

  • Replaced broad wildcard selectors with specific class-based selectors for danger variant styling
  • Added explicit styling for keyboard binding hints ([data-kbd-chord]) in hover and active states
  • Added two new Storybook stories demonstrating keyboard shortcuts and trailing counts with the danger variant

Reviewed Changes

Copilot reviewed 4 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/ActionList/ActionList.module.css Updated danger variant CSS selectors and added keybinding hint styles for hover/active states
packages/react/src/ActionList/ActionList.features.stories.tsx Added WithKeyboardShortcuts and WithTrailingCount stories with danger variant examples
e2e/components/ActionList.test.ts Added E2E test entries for the two new stories
.playwright/snapshots/**/*.png Visual regression test snapshots for new stories across all themes
.changeset/selfish-pigs-chew.md Changeset documenting the patch-level change
Comments suppressed due to low confidence (1)

packages/react/src/ActionList/ActionList.module.css:204

  • Missing comma in CSS selector list. The selector .LeadingVisual, on line 203 should be followed by & for the next selector to maintain proper specificity. The current code has:
& .LeadingAction,
.LeadingVisual,
.ItemLabel {

This means .LeadingVisual and .ItemLabel are being selected globally, not scoped to the [data-variant='danger'] element. It should be:

& .LeadingAction,
& .LeadingVisual,
& .ItemLabel {

The same issue exists on lines 214-215 (hover state) and lines 231-232 (active state).

    }

    /* active state [aria-current] */

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/7187

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 19, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@langermank langermank enabled auto-merge November 19, 2025 19:52
@langermank langermank added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 46a7ebe Nov 20, 2025
59 checks passed
@langermank langermank deleted the actionlist-danger-fixes branch November 20, 2025 22:05
@primer primer bot mentioned this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants