-
Notifications
You must be signed in to change notification settings - Fork 646
ActionBar: Add padding to Divider when gap="none" #7223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c70eeaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a spacing issue in the ActionBar component by adding conditional horizontal padding to the Divider when gap="none" is set. The fix ensures that dividers maintain appropriate spacing even when no gap is applied between ActionBar items.
Key Changes
- Added 8px horizontal padding to
ActionBar.Dividerthat only applies whengap="none" - Used CSS nesting to conditionally apply styles based on the
data-gapattribute - Added changeset for patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/ActionBar/ActionBar.module.css | Added nested .Divider selector within gap="none" block to apply 8px horizontal padding using --base-size-8 design token |
| .changeset/mean-facts-brush.md | Added changeset documenting the patch fix for ActionBar Divider spacing |
baa4f48 to
fc91664
Compare
hectahertz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix ✨
|
😢 Hi from github/github-ui. The integration workflow has failed: https://github.com/github/github-ui/actions/runs/19577160518 |
Fixes the spacing issue when
ActionBarhasgap="none"set.Closes #6136
Changelog
Added conditional horizontal padding (
8pxon each side) toActionBar.Dividerthat only applies whengap="none"Rollout strategy
Testing & Reviewing
Merge checklist