Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

Fixes the spacing issue when ActionBar has gap="none" set.

Closes #6136

Changelog

Added conditional horizontal padding (8px on each side) to ActionBar.Divider that only applies when gap="none"

Rollout strategy

  • Patch release

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

🦋 Changeset detected

Latest commit: c70eeaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 19, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a spacing issue in the ActionBar component by adding conditional horizontal padding to the Divider when gap="none" is set. The fix ensures that dividers maintain appropriate spacing even when no gap is applied between ActionBar items.

Key Changes

  • Added 8px horizontal padding to ActionBar.Divider that only applies when gap="none"
  • Used CSS nesting to conditionally apply styles based on the data-gap attribute
  • Added changeset for patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/ActionBar/ActionBar.module.css Added nested .Divider selector within gap="none" block to apply 8px horizontal padding using --base-size-8 design token
.changeset/mean-facts-brush.md Added changeset documenting the patch fix for ActionBar Divider spacing

Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix ✨

@primer-integration
Copy link

😢 Hi from github/github-ui. The integration workflow has failed: https://github.com/github/github-ui/actions/runs/19577160518

@liuliu-dev liuliu-dev added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit f9fb9eb Nov 21, 2025
49 of 50 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/add-padding-to-action-bar-divider branch November 21, 2025 19:42
@primer primer bot mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants