Skip to content

Conversation

@pimeys
Copy link
Contributor

@pimeys pimeys commented Feb 24, 2021

In 2.17.0, a shared default object will lead to panic when introspecting. 2.18.0 fixes the panic, but how we handle them should be in our documentation.

@mhwelander
Copy link
Contributor

🙏 You're the best!

Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need an issue about this to link in the docs? The docs look good!

@pimeys
Copy link
Contributor Author

pimeys commented Feb 24, 2021

Do you think we need an issue about this to link in the docs? The docs look good!

We do not have one yet. This kind of needs @prisma/product input maybe?

@pimeys pimeys force-pushed the sql-server-default-values branch from 91cd2bd to 1368fa0 Compare February 24, 2021 17:34
@albertoperdomo
Copy link
Contributor

Do you think we need an issue about this to link in the docs? The docs look good!

You mean to track the potential implementation to support this? I don't think we need a GH issue for every single gap. Instead, I would encourage users to request support via GH if they care about it.

That said, I'm open to suggestions and if we know already users want this we could create it.

@mhwelander mhwelander merged commit 01f0e04 into master Mar 4, 2021
@mhwelander mhwelander deleted the sql-server-default-values branch March 4, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants