fix: tab titles not showing | Prisma
#5316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hamirmahal is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
Without this change
|
Contributor
Author
With this change
Docs homepage with this change
|
Contributor
|
👋🏾 @hamirmahal Thanks for looking into this. I've shared your PR internally for someone to review & share feedback on your PR. 🙂 |
ruheni
approved these changes
Sep 18, 2023
Contributor
ruheni
left a comment
ruheni
left a comment
There was a problem hiding this comment.
Thanks again for the contribution 🙏
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@nilubava You're welcome! Thanks for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this PR
Tab titles don't show
| Prisma, but I think they should. If I favorite a Prisma docs page, I'd like to be able to find it easily by typingprismainto my browser's address bar, as opposed to trying to remember the specific title of the page I favorited.Changes
This hardcodes
homepagetofalseinsrc/templates/docs.tsx.What issue does this fix?
This change fixes #5315.