Skip to content

Conversation

@nurul3101
Copy link
Member

@nurul3101 nurul3101 commented Sep 19, 2025

Summary by CodeRabbit

  • Documentation
    • Added a new section, “Usage with Prisma Accelerate or Prisma Postgres,” explaining how to use Prisma Client without Rust engines. Covers setting engineType="client" in the generator, re-generenerating the client, extending with Accelerate, and running queries without changes. Clarifies that driver adapters should not be used with this approach and includes compatibility notes for the previous Preview guidance.

@nurul3101 nurul3101 self-assigned this Sep 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2025

Walkthrough

Adds a new documentation section on using Prisma ORM without Rust engines (with Prisma Accelerate or Prisma Postgres) and duplicates the same section within the file.

Changes

Cohort / File(s) Summary
Documentation: Prisma Accelerate/Postgres usage
content/200-orm/200-prisma-client/000-setup-and-configuration/300-no-rust-engine.mdx
Added a section detailing engineType="client", re-generating Prisma Client, using $extends(withAccelerate()), and noting no query changes; includes a duplicate of the same section; clarifies not to use driver adapters with this approach.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately summarizes the primary change in the PR — adding usage instructions for a Rust-free ORM workflow with Prisma Postgres and Prisma Accelerate — and directly reflects the added documentation section in the diff, so a reviewer can immediately understand the intent. It is clear and focused enough to serve as the main-change summary.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/rust-free-orm-with-ppg

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@github-actions
Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@nurul3101
Copy link
Member Author

Implements #DC-5433

@cloudflare-workers-and-pages
Copy link

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9473230
Status: ✅  Deploy successful!
Preview URL: https://ea3f8b79.docs-51g.pages.dev
Branch Preview URL: https://feat-rust-free-orm-with-ppg.docs-51g.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
content/200-orm/200-prisma-client/000-setup-and-configuration/300-no-rust-engine.mdx (2)

28-30: Align prerequisites with GA version (v6.16.0+).

GA for the Rust‑free ORM is v6.16.0; requiring v6.15.0 risks users hitting pre‑GA behavior. Update the prerequisite accordingly. (prisma.io)

Apply this diff:

-### Prerequisites
-
-- Prisma ORM v6.15.0 (or later)
+### Prerequisites
+
+- Prisma ORM v6.16.0 (or later)

270-275: Preview section: import path vs. generator output is inconsistent.

The Preview generator sets output = "../generated/prisma", but some samples import from @prisma/client. Either drop output or switch those imports to the output path. Easiest fix: keep the output line and change the three imports. Users will otherwise copy/paste broken code.

-import { PrismaClient } from '@prisma/client'
+import { PrismaClient } from './generated/prisma'

Apply to:

  • D1 sample (Line 357)
  • PlanetScale sample (Line 395)
  • Neon Serverless sample (Line 437)

Also applies to: 357-372, 392-399, 436-446

🧹 Nitpick comments (6)
content/200-orm/200-prisma-client/000-setup-and-configuration/300-no-rust-engine.mdx (6)

15-19: Clarify driver adapter requirement (not used with Accelerate or Prisma Postgres).

The blanket “required” statement conflicts with the section below for Accelerate/Prisma Postgres. Tighten the wording here. (prisma.io)

 - required usage of [driver adapters](/orm/overview/databases/database-drivers#driver-adapters) for database connection management
+ - [driver adapters](/orm/overview/databases/database-drivers#driver-adapters) are required for direct database connections (not when using Prisma Accelerate or Prisma Postgres)

42-46: Grammar: “need to re‑generate.”

Minor wording fix.

-To make the configuration take effect, you need re-generate Prisma Client:
+To make the configuration take effect, you need to re-generate Prisma Client:

233-237: Grammar: “need to re‑generate.”

Same nit as above.

-To make the configuration take effect, you need re-generate Prisma Client:
+To make the configuration take effect, you need to re-generate Prisma Client:

279-283: Grammar: “need to re‑generate.”

Same nit in Preview section.

-To make the feature flags take effect, you need re-generate Prisma Client:
+To make the feature flags take effect, you need to re-generate Prisma Client:

231-237: Optional: mention “--no-engine” for serverless/edge with Accelerate.

Docs recommend generating without engines when using Accelerate in serverless/edge. Adding a one‑line tip here helps. (prisma.io)

 ```terminal
 npx prisma generate

+Tip: For serverless or edge runtimes, generate without engines:
+terminal +npx prisma generate --no-engine +


---

`325-329`: **Typo: “Serverles” → “Serverless”.**

Fix tab label.

```diff
-<TabItem value="Neon Serverles">
+<TabItem value="Neon Serverless">
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12d19c5 and 9473230.

📒 Files selected for processing (1)
  • content/200-orm/200-prisma-client/000-setup-and-configuration/300-no-rust-engine.mdx (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-11T09:40:55.237Z
Learnt from: ankur-arch
PR: prisma/docs#7066
File: content/200-orm/200-prisma-client/700-debugging-and-troubleshooting/245-troubleshooting-binary-size-issues.mdx:8-22
Timestamp: 2025-08-11T09:40:55.237Z
Learning: When the queryCompiler preview feature is enabled in Prisma ORM (v6.7.0+), it does not require Rust engines for CLI tools like `prisma migrate` or `prisma db pull`. The previous understanding that CLI tools would still need Rust binaries even with queryCompiler enabled is incorrect.

Applied to files:

  • content/200-orm/200-prisma-client/000-setup-and-configuration/300-no-rust-engine.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Check internal links
  • GitHub Check: runner / linkspector
  • GitHub Check: Lost Pixel
🔇 Additional comments (2)
content/200-orm/200-prisma-client/000-setup-and-configuration/300-no-rust-engine.mdx (2)

217-252: Accelerate/Prisma Postgres guidance looks correct—links/requirements OK.

The “no adapters; use withAccelerate()” guidance matches current docs; Prisma Postgres requires applying the Accelerate extension. Consider verifying final slugs (/accelerate and /postgres) before merge. (prisma.io)


33-38: Note on engineType and generators (FYI).

engineType = "client" is now valid for both prisma-client and prisma-client-js, so keeping the “or prisma-client-js” comment is OK. (prisma.io)

Also applies to: 221-229

@nurul3101 nurul3101 merged commit f069fa0 into main Sep 19, 2025
9 checks passed
@nurul3101 nurul3101 deleted the feat/rust-free-orm-with-ppg branch September 19, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants