-
Notifications
You must be signed in to change notification settings - Fork 855
feat: DC-5662 Update glossary + dataguide index #7185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds two new documentation pages under the Prisma Data Guide (an index page and a comprehensive database glossary) and updates the spellcheck dictionary ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx(1 hunks)content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/index.mdx(1 hunks)
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Outdated
Show resolved
Hide resolved
Deploying docs with
|
| Latest commit: |
51d05fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6d762ad.docs-51g.pages.dev |
| Branch Preview URL: | https://feat-dc-5662-dataguide-migra.docs-51g.pages.dev |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
ded4888 to
94172c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 21
🧹 Nitpick comments (1)
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/index.mdx (1)
2-5: Use consistent “Prisma Data Guide” naming.Current uses “Dataguide”; elsewhere we use “Data Guide”. Align title, metaTitle, and section header.
-title: 'Dataguide' -metaTitle: 'Prisma Dataguide articles' +title: 'Prisma Data Guide' +metaTitle: 'Prisma Data Guide articles' @@ -## Prisma Dataguide articles +## Prisma Data Guide articlesAlso applies to: 14-16
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx(1 hunks)content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/index.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Check internal links
- GitHub Check: runner / linkspector
- GitHub Check: Cloudflare Pages
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Outdated
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Outdated
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Outdated
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Outdated
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
cSpell.json(1 hunks)content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx(1 hunks)content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/index.mdx(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Documentation Checks
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/index.mdx
[error] 2-2: Unknown word (Dataguide) detected by cspell. Command failed: cspell --config ./cSpell.json "content/**/*.mdx" --no-progress (exit code 1).
[error] 3-3: Unknown word (Dataguide) detected by cspell. Command failed: cspell --config ./cSpell.json "content/**/*.mdx" --no-progress (exit code 1).
[error] 14-14: Unknown word (Dataguide) detected by cspell. Command failed: cspell --config ./cSpell.json "content/**/*.mdx" --no-progress (exit code 1).
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: runner / linkspector
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cSpell.json (1)
101-116: Additions LGTM; “Dataguide” now included (unblocks cSpell).Entries look correct. Please verify both case variants are needed (e.g., Nonrepeatable/nonrepeatable, Superkey/superkey). If only one is used, drop the other to keep the list lean. Optional: dedupe existing duplicates elsewhere in this list in a follow-up.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cSpell.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: runner / linkspector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (4)
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx (4)
561-567: Fix verb agreement in the encoding definition.Line 563 currently says “can represents”; it should be “can represent”. While you’re here, capitalize “Unicode” and use the “UTF encodings” phrasing.
-Encoding is a system that translates between a character system that can represents the components used in written language and a digital representation that the computer can store and operate on. Different encoding systems have been developed with a wide variety of character ranges. Some are targeted at specific languages or language families (like ASCII) while others attempt to provide representation for many different languages (like the unicode UTF varieties). +Encoding is a system that translates between a character system that can represent the components used in written language and a digital representation that the computer can store and operate on. Different encoding systems have been developed with a wide variety of character ranges. Some are targeted at specific languages or language families (like ASCII) while others attempt to provide representation for many different languages (like the Unicode UTF encodings).
595-603: Grammar fix: “Eventually consistent systems…”.Line 600 still says “Eventual consistent systems”; switch to the adverbial form.
-Eventual consistent systems make the choice to favor availability +Eventually consistent systems make the choice to favor availability
1506-1511: Subject–verb agreement for “Upsert operations”.Line 1508 says “Upsert operations consists…”; use the plural verb.
- inserts a new entry when no current entry is found. Upsert operations consists + inserts a new entry when no current entry is found. Upsert operations consist
1569-1573: Hyphenate “write-ahead logging/log”.Line 1571 should hyphenate both occurrences for consistency.
- with write ahead logging, the system records its intentions to a durable write ahead log + with write-ahead logging, the system records its intentions to a durable write-ahead log
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: runner / linkspector
- GitHub Check: Check internal links
Fixes #DC-5662
Summary by CodeRabbit