-
Notifications
You must be signed in to change notification settings - Fork 856
DC-6305 Quickstart broken redirect #7289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
WalkthroughUpdated four MDX Redirect target paths to new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used🧠 Learnings (4)📚 Learning: 2025-10-08T16:23:00.388ZApplied to files:
📚 Learning: 2025-10-08T16:23:00.388ZApplied to files:
📚 Learning: 2025-10-08T16:22:57.129ZApplied to files:
📚 Learning: 2025-10-14T11:41:08.844ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Comment |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/500-reference/250-error-reference.mdx
Errors in 200-orm/800-more/300-upgrade-guides/800-upgrade-from-prisma-1/06-upgrading-prisma-binding-to-sdl-first.mdx
Errors in 200-orm/800-more/400-comparisons/04-prisma-and-drizzle.mdx
Errors in 250-postgres/1200-more/1000-faq.mdx
Errors in 800-guides/050-migrate-from-mongoose.mdx
Errors in 800-guides/370-bun.mdx
|
Deploying docs with
|
| Latest commit: |
6c935bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ceb885f7.docs-51g.pages.dev |
| Branch Preview URL: | https://dc-6306-quickstart-broken-re-bqw3.docs-51g.pages.dev |
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/300-prisma-in-your-stack/01-rest.mdx
Errors in 200-orm/050-overview/300-prisma-in-your-stack/02-graphql.mdx
Errors in 200-orm/200-prisma-client/600-observability-and-logging/250-opentelemetry-tracing.mdx
Errors in 200-orm/500-reference/250-error-reference.mdx
Errors in 800-guides/050-migrate-from-mongoose.mdx
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/200-orm/025-getting-started/10-quickstart.mdx (1)
11-11: Clarify the intent of commenting out vs. removing the redirect.The redirect is disabled by commenting rather than removing it entirely. While this aligns with disabling the broken redirect (per the PR objectives), it's worth clarifying whether this is:
- A temporary measure pending further routing restructuring?
- An intentional reference to keep the old path pattern visible?
- A conservative approach to avoid accidentally breaking anything?
This will help future maintainers understand the design decision.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/200-orm/025-getting-started/10-quickstart.mdx(1 hunks)content/200-orm/025-getting-started/20-add-to-existing-project.mdx(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- content/200-orm/025-getting-started/20-add-to-existing-project.mdx
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-10-08T16:22:57.129Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:50-66
Timestamp: 2025-10-08T16:22:57.129Z
Learning: In `.mdx` files, do NOT flag or suggest changes for the following code quality issues even if they represent poor practices: React anti-patterns (using var instead of useState, direct DOM manipulation), missing keys in .map() iterations, non-serializable props in getServerSideProps, unused variables, missing error handling, SQL injection vulnerabilities (unless actively showing how to fix them), insecure cookie settings, missing TypeScript types, PrismaClient instantiation patterns, or any other code quality, security, or performance issues. Documentation code snippets are copied from source code and often intentionally show "before" examples or common mistakes.
Applied to files:
content/200-orm/025-getting-started/10-quickstart.mdx
📚 Learning: 2025-10-08T16:23:00.388Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:85-90
Timestamp: 2025-10-08T16:23:00.388Z
Learning: For .mdx files in the prisma/docs repository: Only flag code snippets for (1) exposed secrets with real-looking values that should be placeholders (e.g., API keys, database passwords, AWS credentials), or (2) blatant syntax errors like missing parentheses, brackets, braces, or mismatched delimiters. Do not flag code quality issues, anti-patterns, security vulnerabilities, missing error handling, unused variables, or any other bad practices, as documentation intentionally shows problematic code.
Applied to files:
content/200-orm/025-getting-started/10-quickstart.mdx
📚 Learning: 2025-10-14T11:41:08.844Z
Learnt from: carlagn
Repo: prisma/docs PR: 7183
File: content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx:561-567
Timestamp: 2025-10-14T11:41:08.844Z
Learning: Ignore the file `content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx` in future reviews as per user request. Issues in this file were addressed in PR #7185.
Applied to files:
content/200-orm/025-getting-started/10-quickstart.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/500-reference/250-error-reference.mdx
Errors in 800-guides/050-migrate-from-mongoose.mdx
Errors in 800-guides/370-bun.mdx
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
content/200-orm/025-getting-started/10-quickstart.mdx(1 hunks)content/200-orm/025-getting-started/20-add-to-existing-project.mdx(1 hunks)content/250-postgres/50-getting-started/100-quickstart.mdx(1 hunks)content/250-postgres/50-getting-started/200-import-from-existing-database.mdx(1 hunks)static/_redirects(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- content/250-postgres/50-getting-started/100-quickstart.mdx
- content/200-orm/025-getting-started/10-quickstart.mdx
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:50-66
Timestamp: 2025-10-08T16:22:57.129Z
Learning: In `.mdx` files, do NOT flag or suggest changes for the following code quality issues even if they represent poor practices: React anti-patterns (using var instead of useState, direct DOM manipulation), missing keys in .map() iterations, non-serializable props in getServerSideProps, unused variables, missing error handling, SQL injection vulnerabilities (unless actively showing how to fix them), insecure cookie settings, missing TypeScript types, PrismaClient instantiation patterns, or any other code quality, security, or performance issues. Documentation code snippets are copied from source code and often intentionally show "before" examples or common mistakes.
📚 Learning: 2025-10-08T16:22:57.129Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:50-66
Timestamp: 2025-10-08T16:22:57.129Z
Learning: In `.mdx` files, do NOT flag or suggest changes for the following code quality issues even if they represent poor practices: React anti-patterns (using var instead of useState, direct DOM manipulation), missing keys in .map() iterations, non-serializable props in getServerSideProps, unused variables, missing error handling, SQL injection vulnerabilities (unless actively showing how to fix them), insecure cookie settings, missing TypeScript types, PrismaClient instantiation patterns, or any other code quality, security, or performance issues. Documentation code snippets are copied from source code and often intentionally show "before" examples or common mistakes.
Applied to files:
content/200-orm/025-getting-started/20-add-to-existing-project.mdxcontent/250-postgres/50-getting-started/200-import-from-existing-database.mdx
📚 Learning: 2025-10-08T16:23:00.388Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:85-90
Timestamp: 2025-10-08T16:23:00.388Z
Learning: For .mdx files in the prisma/docs repository: Only flag code snippets for (1) exposed secrets with real-looking values that should be placeholders (e.g., API keys, database passwords, AWS credentials), or (2) blatant syntax errors like missing parentheses, brackets, braces, or mismatched delimiters. Do not flag code quality issues, anti-patterns, security vulnerabilities, missing error handling, unused variables, or any other bad practices, as documentation intentionally shows problematic code.
Applied to files:
content/200-orm/025-getting-started/20-add-to-existing-project.mdx
📚 Learning: 2025-10-14T11:41:08.844Z
Learnt from: carlagn
Repo: prisma/docs PR: 7183
File: content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx:561-567
Timestamp: 2025-10-14T11:41:08.844Z
Learning: Ignore the file `content/200-orm/800-more/600-help-and-troubleshooting/050-dataguide/050-database-glossary.mdx` in future reviews as per user request. Issues in this file were addressed in PR #7185.
Applied to files:
content/200-orm/025-getting-started/20-add-to-existing-project.mdxcontent/250-postgres/50-getting-started/200-import-from-existing-database.mdx
📚 Learning: 2025-10-08T16:23:00.388Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:85-90
Timestamp: 2025-10-08T16:23:00.388Z
Learning: For .mdx files in the prisma/docs repository: All headings and titles should use sentence case (e.g., "Getting started with Prisma ORM", "Best practices for authentication"), not title case. Exception: Always preserve exact casing for product names including "Prisma Postgres", "Prisma", "Prisma ORM", and "Prisma Data Platform".
Applied to files:
content/200-orm/025-getting-started/20-add-to-existing-project.mdxstatic/_redirects
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
content/250-postgres/50-getting-started/200-import-from-existing-database.mdx (1)
1-7: LGTM - Clean migration to server-side redirects.The removal of client-side redirect logic in favor of server-side redirects (in
static/_redirects) is the correct approach. This improves performance and maintainability.content/200-orm/025-getting-started/20-add-to-existing-project.mdx (1)
1-7: LGTM - Consistent with redirect migration pattern.The change aligns with the migration strategy to use server-side redirects instead of client-side redirect components.
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/500-reference/250-error-reference.mdx
Errors in 800-guides/050-migrate-from-mongoose.mdx
|
Summary by CodeRabbit