feat(push): handle delete custom type with documents#187
Merged
Conversation
tomaboro
approved these changes
May 19, 2026
Remove the ability to cascade-delete documents when removing a custom type. The CLI now always blocks and directs users to delete pages manually, eliminating the risk of irrecoverable data loss from AI agents or accidental usage in production. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 28c4453. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
xrutayisire
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
BadRequestError+ stable checks on the response body).POST …/core/documents/search(Editor parity:customTypes+limit: 0), enforce the 200 bulk-delete limit, then callDELETE …/core/documentswithcustomtype_idsbefore retrying type deletion.https://{repository}.{host}/builder/working?customTypes={id}.Note
Medium Risk
Moderate risk: changes
prismic pushdelete behavior and introduces new 400-error handling in the sharedrequesthelper, which could affect other callers’ error paths.Overview
prismic pushnow wraps custom type deletions with additional handling: if the delete fails due to associated documents, it queries the document count and throws a clearerCommandErrorinstructing the user to delete documents first, including deep links to the filtered working view and the custom type list.To support this, the core client adds
getDocumentTotalByCustomTypes()(viaPOST core/documents/searchwithlimit: 0), Wroom adds URL builders for the working view and type lists, and the sharedrequest()utility now throws a dedicatedBadRequestErroron HTTP 400 for more reliable detection.Reviewed by Cursor Bugbot for commit 32ac787. Bugbot is set up for automated code reviews on this repo. Configure here.